Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved changes prompt triggered on event forms when geo coordinates entered #5039

Closed
kwa20 opened this issue Apr 11, 2021 · 2 comments
Closed

Unsaved changes prompt triggered on event forms when geo coordinates entered #5039

kwa20 opened this issue Apr 11, 2021 · 2 comments
Assignees
@MateStrysewske
Labels
bug An error or misbehavior of an existing feature (ticket type) events qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Milestone
Sprint 102 - 1.59.0

Comments

@kwa20
Copy link

kwa20 commented Apr 11, 2021

Bug Description

The unsaved changes prompt is triggered on event forms when geo coordinates are entered and no edits have been made.

Steps to Reproduce

  1. Go to any event or create one.
  2. Enter the location and generate geo coordinates, save.
  3. Navigate to different tabs.

Expected Behavior

The prompt should only be shown when actual changes have been made.

Screenshots

unsavedChangesPromptEvents

unsavedChangesPromptEvents2

System Details

  • Device:
  • SORMAS version: 1.58.3
  • Android version/Browser: firefox
  • Server URL: test1401.sormas-oegd.de
  • User Role: admin, national user

Additional Information

cf. #3014
@kwa20 kwa20 added the bug An error or misbehavior of an existing feature (ticket type) label Apr 11, 2021
@MateStrysewske MateStrysewske added this to the Sprint 102 - 1.59.0 milestone Apr 12, 2021
@MateStrysewske MateStrysewske added events vaadin-app Affects the Vaadin application labels Apr 12, 2021
@MateStrysewske MateStrysewske self-assigned this Apr 16, 2021
@MateStrysewske
Copy link
Contributor

@kwa20 For some reason I can't reproduce the problem on my local system (even with the settings that I used to reproduce the other "unsaved changes" warnings that weren't supposed to be there in the first place). I have however provided a potential fix. We'll have to see whether it successfully solves the issue. I'm pretty sure it won't make it worse at least. :)

MateStrysewske added a commit that referenced this issue Apr 19, 2021
@MateStrysewske
(Hopefully) Fixed #5039
01fbdc2
MateStrysewske added a commit that referenced this issue Apr 19, 2021
@MateStrysewske
Revert "(Hopefully) Fixed #5039"
10adcfb 
This reverts commit 01fbdc2.
alexcaruntu-vita pushed a commit that referenced this issue Apr 19, 2021
@MateStrysewske
#4868 - Added validation to not allow birth dates in the future (#5116)
ebbf385 
* #4868 - Added validation to not allow birth dates in the future

* (Hopefully) Fixed #5039

* Revert "(Hopefully) Fixed #5039"

This reverts commit 01fbdc2.

* #4868 - Added birth date validation to case and contact creation

* #4868 - Fix failing tests
@AndyBakcsy-she AndyBakcsy-she added the qa-verified Issue has been tested and verified by QA label Apr 19, 2021
@AndyBakcsy-she
Copy link

Validated ticket on the latest version of sormas 1.59.0-snapshot

@MateStrysewske MateStrysewske mentioned this issue Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MateStrysewske MateStrysewske

Labels
bug An error or misbehavior of an existing feature (ticket type) events qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Sprint 102 - 1.59.0
Development

No branches or pull requests
3 participants
@MateStrysewske @kwa20 @AndyBakcsy-she