Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden fields are still present on creation forms #7743

Closed
kwa20 opened this issue Jan 21, 2022 · 3 comments · Fixed by #7936
Closed

Hidden fields are still present on creation forms #7743

kwa20 opened this issue Jan 21, 2022 · 3 comments · Fixed by #7936
Assignees
@syntakker @adinaflorea9
Labels
bug An error or misbehavior of an existing feature (ticket type) major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) persons qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Milestone
Sprint 111 - 1.68.0

Comments

@kwa20
Copy link

kwa20 commented Jan 21, 2022

Bug Description

#7476 hides specific person fields depending on the server locale. However, nationalHealthId and passportNumber are still visible on case and contact creation forms.

Steps to Reproduce

  1. Open the case directory and create a new case
  2. Check person fields
  3. Repeat for contacts
  4. Convert a contact into a case
  5. Process a lab message

Expected Behavior

Fields should also be hidden on creation forms

Screenshots

hiddenDeFields

System Details

  • Device:
  • SORMAS version: 1.67.0
  • Android version/Browser: chrome
  • Server URL: test1402.sormas.netzlink.com
  • User Role: admin, national user

Additional Information
@kwa20 kwa20 added bug An error or misbehavior of an existing feature (ticket type) persons labels Jan 21, 2022
@MateStrysewske MateStrysewske added major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) vaadin-app Affects the Vaadin application labels Jan 24, 2022
@MateStrysewske MateStrysewske added this to the Sprint 111 - 1.68.0 milestone Jan 24, 2022
@syntakker syntakker self-assigned this Jan 25, 2022
@StefanKock StefanKock added minor Text issues, layouting or cosmetic problems, ... (Severity for bugs/defects) major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) and removed major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) minor Text issues, layouting or cosmetic problems, ... (Severity for bugs/defects) labels Feb 1, 2022
syntakker added a commit that referenced this issue Feb 9, 2022
@syntakker
hide passport and health Id fields #7743
6710900
This was referenced Feb 9, 2022
Closed
Merged
@syntakker
Copy link
Contributor

Fixed for now. I advocate a refactoring as described in #7935.

MateStrysewske added a commit that referenced this issue Feb 9, 2022
@MateStrysewske
Merge pull request #7936 from hzi-braunschweig/bugfix-7743-hide-passp…
5f594dc 
…ort-and-health-id-fields

hide passport and health Id fields #7743
@adinaflorea9 adinaflorea9 self-assigned this Feb 9, 2022
@AndyBakcsy-she
Copy link

AndyBakcsy-she commented Feb 9, 2022 •
edited
Loading

Verified this issue with a FR local environment. The nationalHealthId and passportNumber fields are disabled:

Case creation form:
image

Contact creation form:
image

@adinaflorea9
Copy link

Verified ticket on the local machine and test-de2.sormas.netzlink.com, using the latest version of Sormas 1.69.0-SNAPSHOT from the development branch.

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Feb 10, 2022
This was referenced Feb 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syntakker syntakker

@adinaflorea9 adinaflorea9

Labels
bug An error or misbehavior of an existing feature (ticket type) major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) persons qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Sprint 111 - 1.68.0
Development

Successfully merging a pull request may close this issue.

hide passport and health Id fields #7743 SORMAS-Foundation/SORMAS-Project
6 participants
@syntakker @MateStrysewske @StefanKock @kwa20 @AndyBakcsy-she @adinaflorea9