New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2S_Revision of the 'share requests' directory_ Part 1 [3] #9755
Comments
@SahaLinaPrueger It is not possible to have both incoming and outgoing requests at the same time because incoming and outgoing requests are stored in different database tables and those can't be merged. Is it ok if we remove the 'All' option and the direction column from the table? |
That would be a pity for the workflow and for the consistency of the sormas UI. If we do not find another solution: Another point (to clarify): The column "From / To (Counterpart)" shows the server instance name not the jurisdiction, because we decided yesterday to share with server instance not with jurisdiction. |
To make "incoming" and "outgoing" buttons fixed I can: Which one would you prefer? @SahaLinaPrueger @MateStrysewske @MartinWahnschaffe @markusmann-vg |
@leventegal-she Please implement option Nr.1 so it is consistent across all directories. Just for me to better understand the problem here. |
If we implement 1 or 2 the filter option "status" doubles itself with the buttons "pending" and "accepted". |
That is correct because we have the filter for "Status" we do not need the buttons "Pending" and "Accepted" anymore. They can be removed. |
@leventegal-she The filter status stays, so please implement
|
And thank you very much for developing Nr. 1 and Nr. 2 ! |
@Jan-Boehme
The data structure for incoming and outgoing requests are different and is not possible on the backend to query more than one database table at once and have lazy loading with sort. |
…revoek button on outgoing requests
@AndyBakcsy-she Can you add the correct milestone here? I'm not certain if this should go into 1.75 or 1.76? |
Validated on test.de1 & test.de2 on Version: 1.76.0-SNAPSHOT (378ad16).
|
Translations are not yet available on crowdIn. Please provide. |
@leventegal-she And another thing: Why is the column 'creation date' not renamed to 'share date' as specified? We found 'creation date' confusing because it was not clear what the word 'creation' referred to, so we thought 'share date' would be better. Did you also find 'share date' misleading and 'delivery date' or something similar would be better? Or was it just forgotten to change? |
@leventegal-she: open task for this ticket, before it can be closed. Additional requirements will be taken care of in a new ticket
|
@leventegal-she @markusmann-vg I guess changing the caption of the creationDate field is sufficient? |
OK. For the alignment issue the only solution I see is to set fixed size on some of the columns so there will be less changes when filtering the grid |
reverified ticket after deployment on test-de2 environment |
@leventegal-she @AndyBakcsy-she Buttons INCOMING and OUTGOING are not yet translated on UI. Can you please check this? |
@SahaLinaPrueger I pushed a fix for it |
Problem Description
The 'share request' directory has no filter options. That is a problem, because after a while the directory becomes confusing.
At the moment the 'share requests' directory only shows incoming share requests and not the outgoing ones. That is a problem, because the health departments have no option to get an overview about shared cases/contacts and cannot track the shared cases/contacts.
Also the layout of the overview table does not include necessary information's, that the health departments need to be able to work.
Proposed Change
Pending - Only shares with the value "Pending" in "Status" are displayed.
Accepted - Only shares with the value "Accepted" in "Status" are displayed.
Rejected - Only those shares are displayed that have the value "Rejected" in "Status".
Error - Only shares with the value "Error" in "Status" are displayed.
"" is the default setting, which shows all entries
3. Delete the buttons 'Pending' and 'Accepted'
4. Add the buttons 'Incoming' (German: Eingehend) in the place where the button 'Pending' was previously seen.
-The total number of results for this filter are displayed on the button if the button has been clicked/ is active.
-Clicking on the button 'Incoming' should show all cases/contacts that where shared from another health department to the own health department (status can be: accepted and pending- if user clicks 'reject' the share has to disappear because of data protection reasons).
-Clicking on the button 'Outgoing' should show all cases/ contacts that where shared with another health department (status can be: accepted, pending, revoked and rejected)
(Counterpart)
A double click or a single click on the "eye" button opens the preview of a share (is already implemented)
Acceptance Criteria
Implementation Details
Additional Information
The text was updated successfully, but these errors were encountered: