Fix a potential buffer overflow in CPhysicsManager::GenerateIndexedAr…

…rayForBrush which may cause random crash.
hzqst · May 14, 2024 · cd61bb2 · cd61bb2
1 parent 79618af
commit cd61bb2
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/Plugins/BulletPhysics/physics.cpp b/Plugins/BulletPhysics/physics.cpp
@@ -366,16 +366,7 @@ void CPhysicsManager::GenerateIndexedArrayForBrush(model_t *mod, vertexarray_t *
 	{
 		for (int i = 0; i < mod->nummodelsurfaces; i++)
 		{
-			msurface_t* surf;
-
-			if (g_iEngineType == ENGINE_GOLDSRC_HL25)
-			{
-				surf = (((msurface_hl25_t*)mod->surfaces) + mod->firstmodelsurface + i);
-			}
-			else
-			{
-				surf = mod->surfaces + mod->firstmodelsurface + i;
-			}
+			auto surf = GetWorldSurfaceByIndex(mod->firstmodelsurface + i);
 
 			GenerateIndexedArrayForSurface(surf, vertexarray, indexarray);
 		}