Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/redbox 73 unit test core api #103

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

gecBurton
Copy link
Collaborator

@gecBurton gecBurton commented Mar 13, 2024

Context

We want to unit test the core-api so that we have confidence that the code is working as expected.

Changes proposed in this pull request

  1. I have added unit test for the core-api
  2. I have renamed the core-api endpoints to make the more RESTful https://stackoverflow.blog/2020/03/02/best-practices-for-rest-api-design/
  3. In other parts of the code we were (I was!) erroneously force loading the .env.test when we should be leaving it up to pydantic-settings to work put where the .env file is

Guidance to review

  • do the new tests make sense

Note - there is a lot of duplication of code between the various conftests - I have ignored this for now as I am not sure what we should do about it, if anything.

Relevant links

https://technologyprogramme.atlassian.net/browse/REDBOX-73

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed

@gecBurton gecBurton marked this pull request as draft March 13, 2024 10:03
@gecBurton gecBurton marked this pull request as ready for review March 13, 2024 18:24
@lmwilkigov
Copy link
Collaborator

I like the look of the tests! Just did a minor fix in the actions YAML to call them.

.github/workflows/python-app.yml Outdated Show resolved Hide resolved
@lmwilkigov lmwilkigov merged commit 30596e7 into main Mar 13, 2024
7 checks passed
@lmwilkigov lmwilkigov deleted the feature/REDBOX-73-unit-test-core-api branch March 13, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants