e2e test added #134
Merged
e2e test added #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
252afh
approved these changes
Mar 21, 2024
| @@ -39,6 +39,12 @@ test-ingest: | |||
| poetry run pytest ingest/tests --cov=ingest -v --cov-report=term-missing --cov-fail-under=40 | |||
|
|
|||
| test-django: | |||
| docker compose up -d db --wait db | |||
| data=reformatted_embeddings, | ||
| embedding_id=str(uuid4()), | ||
| model=model, | ||
| model_info=self.get_model_info(model), |
There was a problem hiding this comment.
I wonder if we need this model property if we're also giving back themodel_info that includes the model name as well?
There was a problem hiding this comment.
We can leave it in by all means if you think it would be useful by consuming functions, just spitballing
There was a problem hiding this comment.
@lmwilki will explain! (i think this is a standard way of representing the response)
gecBurton
commented
Mar 21, 2024
gecBurton
force-pushed
the
feature/REDBOX-44-test-end-to-end-file-processing-from-core-api-to-elastic-4
branch
from
ba6af26
to
f635e35
Compare
…ssing-from-core-api-to-elastic-4
gecBurton
deleted the
feature/REDBOX-44-test-end-to-end-file-processing-from-core-api-to-elastic-4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As an Engineer I want an e2e test to know that a change i have made in one service has not adversely affected another.
Changes proposed in this pull request
embed_sentenceshas been moved inmodel_db.pyNote: Whilst trying to remove all the hardcoded model names I have identified a problem whereby the docker image always preloads the default
paraphrase-albert-small-v2so any attempt to use a smaller model actually makes this worse by adding another, albeit smaller, model. I have removed the smaller model until we find a way to resolve this.It is not possible to run this test in CI at this time as the disk runs out of space.
Guidance to review
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-44
Things to check