moved to faststream #143
Merged
moved to faststream #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh gosh, this looks fantastic. So clean ✨ |
gecBurton
force-pushed
the
feature/faststream
branch
from
6591604
to
cf87714
Compare
added 2 commits
March 23, 2024 12:59
gecBurton
commented
Mar 24, 2024
| @@ -48,7 +48,7 @@ jobs: | |||
| mkdir -p data/elastic/ | |||
| chmod 777 data/elastic/ | |||
| cp .env.test .env | |||
| docker compose up -d --wait elasticsearch minio rabbitmq | |||
| docker compose up -d --wait elasticsearch minio | |||
There was a problem hiding this comment.
no need for this in CI anymore
gecBurton
commented
Mar 24, 2024
| @@ -45,8 +45,6 @@ test-django: | |||
| test-integration: | |||
| poetry install --no-root --no-ansi --with dev --without ai,streamlit-app,api,django-app,pytest-django,worker,ingest | |||
| poetry run pytest tests | |||
| docker compose up -d --wait db | |||
There was a problem hiding this comment.
fixing an unrelated error
gecBurton
commented
Mar 25, 2024
gecBurton
commented
Mar 25, 2024
gecBurton
commented
Mar 25, 2024
gecBurton
commented
Mar 25, 2024
| @@ -1,8 +1,34 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
largely brought this back exactly as it was
gecBurton
commented
Mar 25, 2024
|
|
||
| RUN --mount=type=cache,target=$POETRY_CACHE_DIR poetry install --no-root --no-ansi --with worker,ingest --without ai,dev,api,streamlit-app | ||
|
|
||
| FROM python:3.11-slim-buster as runtime |
There was a problem hiding this comment.
this contradicts everything above it
gecBurton
commented
Mar 25, 2024
| from redbox.models.llm import Embedding, EmbeddingResponse | ||
|
|
||
| MODEL_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..", "models") | ||
|
|
||
| log = logging.getLogger() | ||
| log.setLevel(logging.INFO) | ||
|
|
||
| env = Settings() | ||
|
|
||
|
|
||
| class SentenceTransformerDB(collections.UserDict): |
There was a problem hiding this comment.
i have removed the dependancy on the Settings here so that it can be called without an .env existing, e.g. at build time
lmwilkigov
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
faststream is an abstraction layer for various queuing technologies, by using this instead of
pikadirectly we can:Changes proposed in this pull request
ingestandembedworkers have been rewrittenpikahas been removedAlso, the .env was missing from the Dockerfile(s) which caused the e2e tests to fail
Guidance to review
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-99
Things to check