fix integration tests #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
commented
Mar 28, 2024
| @@ -92,16 +91,7 @@ def s3_client(self): | |||
|
|
|||
| raise NotImplementedError | |||
|
|
|||
| def sqs_client(self): | |||
There was a problem hiding this comment.
no longer needed
gecBurton
commented
Mar 28, 2024
|
|
||
| pytest.fail(reason=f"failed to get embedded chunks within {timeout} seconds") | ||
| if not embeddings_found: |
gecBurton
commented
Mar 28, 2024
| @@ -42,7 +42,6 @@ class Settings(BaseSettings): | |||
|
|
|||
| redis_host: str = "redis" | |||
| redis_port: int = 6379 | |||
| redis_password: str = "guest" | |||
There was a problem hiding this comment.
i have removed this until we work out how to get auth working
There was a problem hiding this comment.
Is this mentioned somewhere on JIRA as something to fix?
rachaelcodes
approved these changes
Mar 28, 2024
gecBurton
deleted the
bugfix/integration-tests-not-working-with-redis-auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The integration tests were broken when we moved from
rabbitmqtoredis, this is because theredisusername/password was incorrectly set up. Fixing theredisauth will be tackled in another ticket, this PR just gets the tests passing again.Changes proposed in this pull request
redisauth has been removedGuidance to review
does
make test-integrationwork for you?Relevant links
Things to check