-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add govuk frontend loading with scss and npm #98
Conversation
@duncanjbrown, any thoughts on the compression error in the build here? |
This is down to a nuance of The fix is to make sure this isn't touched is to mount a persistent volume on the node_modules folder
then correct the path in style.scss, which needs to be relative to
and you need to correct the
You can confirm it's built correctly with
and you should see Further reading: https://stackoverflow.com/questions/29181032/add-a-volume-to-docker-but-exclude-a-sub-folder |
9dd4861
to
22ed2c5
Compare
…ed dockerfile to reflect changes
c6ba872
to
8b32b62
Compare
Context
Adding govuk frontend loading in the style Duncan implemented
Changes proposed in this pull request
Guidance to review
Check the app loads and the govuk styling is in place
Relevant links
Things to check