Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dataclasses for json deserialisation #609

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Use dataclasses for json deserialisation #609

merged 4 commits into from
Jun 18, 2024

Conversation

brunns
Copy link
Collaborator

@brunns brunns commented Jun 18, 2024 •
edited
Loading

Context

Changes proposed in this pull request

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

gecBurton
gecBurton approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunns brunns merged commit fd4eaf0 into main Jun 18, 2024
8 checks passed
@brunns brunns deleted the feature/use-dataclasses-for-json-deserialisation branch June 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gecBurton gecBurton gecBurton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunns @gecBurton