Added lambda for deleting expired files #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
252afh
force-pushed
the
feature/deletion-lambda
branch
from
06ca6ce
to
e66ab6b
Compare
rachaelcodes
force-pushed
the
feature/deletion-lambda
branch
from
5c0bad8
to
e7fda17
Compare
rachaelcodes
force-pushed
the
feature/deletion-lambda
branch
from
6a3f28d
to
9c01c33
Compare
3 tasks
252afh
force-pushed
the
feature/deletion-lambda
branch
from
e800f60
to
624a760
Compare
…60 seconds instead of 600
rachaelcodes
force-pushed
the
feature/deletion-lambda
branch
from
624a760
to
0c346cb
Compare
rachaelcodes
changed the title
gecBurton
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
code looks good. maybe some tech debt to consider int eh future here https://technologyprogramme.atlassian.net/browse/REDBOX-547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds a new lambda for deleting expired files.
Changes proposed in this pull request
Adds a new lambda that checks for expired files, deletes them (and related chunks) from Elastic, removes them from s3 and then updates the django record.
core infra changes: https://github.com/i-dot-ai/i-ai-core-infrastructure/pull/320
Guidance to review
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-460
Things to check