Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announce when message streaming has completed to screen-reader users #792

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

KevinEtchells
Copy link
Contributor

Context

When testing with a screen-reader, I noticed it was announced when a new message is loading, but not when it has completed - leaving users to guess when it's complete.

Changes proposed in this pull request

  • Announce "Response complete" to screen-reader users when a response has finished streaming

Guidance to review

  • Check the code looks sensible
  • If you can't test with a screen-reader, I understand! And I'd be happy to give you a demo, if you want. But I'm happy it's working.

Copy link
Collaborator

@brunns brunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KevinEtchells KevinEtchells merged commit 696d6f8 into main Jul 17, 2024
9 checks passed
@KevinEtchells KevinEtchells deleted the bugfix/streaming-complete-screen-reader branch July 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants