Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 support #113

Closed
amilajack opened this issue Jan 20, 2018 · 6 comments · Fixed by #123
Closed

React 16 support #113

amilajack opened this issue Jan 20, 2018 · 6 comments · Fixed by #123
Labels

Comments

@amilajack
Copy link

Does this module work with react 16? If so I'd love to bump the peerDeps of react and react-dom

@i-like-robots
Copy link
Owner

Yes it does - I've bumped in the V6 branch (afd26a1) but not in master.

I'm aware there are a few projects still using V15 so perhaps it needs to be quite loose.

@i-like-robots i-like-robots mentioned this issue Jan 21, 2018
Closed
12 tasks
@GazzaHazza
Copy link

Could you maybe do this:

"peerDependencies": {
  "react": "^15.0.0 || ^16.0.0",
"react-dom": "^15.0.0 || ^16.0.0"
}

Would allow both R15 and R16?

@i-like-robots
Copy link
Owner

Yep, looks good - we did the same when we went from v0.14 to v15 😄

@GazzaHazza
Copy link

I can create a PR if you like or is it already in place?

@i-like-robots
Copy link
Owner

i-like-robots commented Jan 22, 2018 via email

@GazzaHazza
Copy link

Im not at my laptop so i cant either. I will in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants