Implement min / max tags and validation - Fixes #226 #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandernst
force-pushed
the
min_max_tags
branch
from
934060b
to
42e37da
Compare
alexandernst
force-pushed
the
min_max_tags
branch
from
42e37da
to
662928f
Compare
|
@i-like-robots the -0.6% comes from the private method. I'm not really sure if/how I can make the code coverage cover that. |
| border: 1px solid green; | ||
| } | ||
|
|
||
| .react-tags.react-tags__invalid { |
There was a problem hiding this comment.
I think we should name these classes is-valid and is-invalid
| validationState | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think we need to store this in state, because the implementation of _getValidationState() is so simple I think it's safe to call within render().
|
Are there any updates on this? also linking to #226 |
|
Also wondering if there are any updates on this? |
i-like-robots
force-pushed
the
main
branch
2 times, most recently
from
07a315c
to
dbd521f
Compare
|
Closing as validation is now supported in v7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the changes in PR #228