Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcing: Add deliveryInfo to interface StockProvider GetStock #280

Merged
merged 2 commits into from Nov 11, 2020

Conversation

masmrlar
Copy link
Contributor

Implementing StockProviders require the deliveryInfo for specific stock checks.

Implementing StockProviders require the deliveryInfo for specific stock checks.
@danielpoe
Copy link
Member

Can you give details for the use case?

@masmrlar
Copy link
Contributor Author

@danielpoe a usecase for this is for example a requirement where the StockProvider has to use a specific logic based on product data/attributes and the deliveryInfo (like DeliveryCode) - to override stock data.

And a pretty specific usecase is: we want to have a delivery specific alwaysInStock logic - let's call it alwaysInStockForDelivery beneath alwaysInStock.

@carstendietrich carstendietrich changed the title 235473: Added deliveryInfo to interface StockProvider GetStock sourcing: Add deliveryInfo to interface StockProvider GetStock Nov 11, 2020
Copy link
Member

@carstendietrich carstendietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can't hurt that the stock also gets the delivery info, never the less it's a breaking change. Please, update the project's main CHANGELOG.md and mark this change as breaking.

Copy link
Member

@carstendietrich carstendietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@carstendietrich carstendietrich merged commit 0057713 into master Nov 11, 2020
@carstendietrich carstendietrich deleted the 235473-provide-deliveryInfo-for-stockprovider branch November 11, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants