fix for if the same resource name is in a root and sub dir. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all it should not hit the root one. everything is the same as lessc compiler is outputitng except the "off.css" which url15 works like the others that we do resolve it even if it shouldn't according to lessc Because url14 'test.jpg' is already mapping on the root image so so url15 '../test.jpg' shouldn't be there (its above root). But we fall back to always map it on the root anyway,
|
It should be called the ReaderFactory.openStream with the 3 parameters. In the other case it would break for the users which use its own implementation of ReaderFactory. |
|
done now openStream(url) is not called anymore from the data-uri code only the 3 args |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then with local or all it should not hit the root one.
everything is the same as lessc compiler is outputting except the
"off.css" which url15 works like the others that we do resolve it even
if it shouldn't according to lessc
Because url14 'test.jpg' is already mapping on the root image so
so url15 '../test.jpg' shouldn't be there (its above root).
But we fallback to always map it on the root anyway,