Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apulse wrapper does not understand spaces in command line arguments #1

Closed
patrakov opened this issue Sep 19, 2014 · 1 comment
Closed

apulse wrapper does not understand spaces in command line arguments #1

patrakov opened this issue Sep 19, 2014 · 1 comment
Labels
fixed

Comments

@patrakov
Copy link 

apulse fooprogram "bar baz"

will call fooprogram with two arguments, bar and baz, instead of one bar baz with a space in the middle.
@i-rinat
Copy link
Owner

i-rinat commented Sep 19, 2014

fixed in b9b0d96

@i-rinat i-rinat added the fixed label Sep 19, 2014
@i-rinat i-rinat closed this as completed Sep 21, 2014
@WildLynxDev WildLynxDev mentioned this issue Jul 26, 2016
Closed
@Catoptrix Catoptrix mentioned this issue Sep 18, 2018
Closed
Miouyouyou added a commit to Miouyouyou/apulse that referenced this issue Oct 20, 2019
@Miouyouyou
stream: Check the key before invoking g_hash_table_remove
bf146f0 
Turns out that I hit a bug where pa_stream_unref would
call g_hash_table_remove with a NULL key.

Thanks for the lightweight and smooth error handling from
Glib, g_hash_table_remove generated an ABORT call, crashing
some Unity3D games I was trying to start.
Now, you also CANNOT call g_hash_table_lookup with a NULL
key. That also generate a crash... Ugh...

So, yeah, we first check that the key is not 0, then check
if the key is actually inside the Hash table and THEN remove
it.

Note, here's my ~/.asoundrc, just in case :
defaults.pcm.!card Audio
defaults.ctl.!card Audio

Audio being :
card 3: Audio [DigiHug USB Audio], device 0: USB Audio [USB Audio]
  Subdevices: 0/1
  Subdevice #0: subdevice #0
card 3: Audio [DigiHug USB Audio], device 1: USB Audio [USB Audio i-rinat#1]
  Subdevices: 1/1
  Subdevice #0: subdevice #0

I'm using a FiiO device for sound output.

Signed-off-by: Miouyouyou (Myy) <myy@miouyouyou.fr>
@tudorapo tudorapo mentioned this issue Nov 4, 2019
Closed
@JosephHenley JosephHenley mentioned this issue Nov 4, 2019
Open
borine pushed a commit to borine/apulse that referenced this issue Mar 24, 2022
@Miouyouyou @borine
stream: Check the key before invoking g_hash_table_remove
e27320c 
Turns out that I hit a bug where pa_stream_unref would
call g_hash_table_remove with a NULL key.

Thanks for the lightweight and smooth error handling from
Glib, g_hash_table_remove generated an ABORT call, crashing
some Unity3D games I was trying to start.
Now, you also CANNOT call g_hash_table_lookup with a NULL
key. That also generate a crash... Ugh...

So, yeah, we first check that the key is not 0, then check
if the key is actually inside the Hash table and THEN remove
it.

Note, here's my ~/.asoundrc, just in case :
defaults.pcm.!card Audio
defaults.ctl.!card Audio

Audio being :
card 3: Audio [DigiHug USB Audio], device 0: USB Audio [USB Audio]
  Subdevices: 0/1
  Subdevice #0: subdevice #0
card 3: Audio [DigiHug USB Audio], device 1: USB Audio [USB Audio i-rinat#1]
  Subdevices: 1/1
  Subdevice #0: subdevice #0

I'm using a FiiO device for sound output.

Signed-off-by: Miouyouyou (Myy) <myy@miouyouyou.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i-rinat @patrakov