-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Firefox, muting one tab mutes them all #46
Comments
This makes the "mute" button on each Firefox tab work separately. Without this patch, muting one tab mutes them all. Fixes i-rinat#46.
Decided to give it a shot at fixing this! I sent a PR that seems to work well. Thank you for a clear codebase, it was easy to find my way around the code. :) |
Oops. I assumed volumes are per-context rather that per-stream. And while code was written, I was thinking about how strange it's that application has to make own volume scaling. Thank you for fixing this. |
Yay, thank you for reviewing quickly! Can't wait to get the next release merged in GoboLinux. :) |
Using Firefox 52 with apulse 0.1.9 and the dmix ALSA 1.1.3 plugin, Firefox can play audio from multiple tabs simultaneously and it works great.
When playing audio in multiple tabs, each tab gets a mute button. With direct ALSA+dmix in Firefox 51, this worked well, and tabs could be muted individually. With apulse, however, pressing "mute" on one tab is muting them all.
When I disable dmix, Firefox+apulse can't play multiple tabs simultaneously, so mixing is happening at ALSA level, so I assume apulse is sending separate streams for each tab via ALSA. I note also that the device does not get muted, so I believe apulse is muting "via software" (ie, not sending a mute command to the actual device).
This is my ~/.asoundrc to get software mixing via dmix working (but I have no reason to assume the same issue isn't happening with cards that do hardware mixing)
Thank you for apulse, it has become an essential tool in my system!
The text was updated successfully, but these errors were encountered: