Fix lint warnings

ivnsch · Nov 12, 2019 · 4140366 · 4140366
1 parent 78d8e56
commit 4140366
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/Lib.hs b/src/Lib.hs
@@ -4,4 +4,4 @@ import OrderQuantity
 import OrderTakingDomain
 
 someFunc :: IO ()
-someFunc = putStrLn $ show $ KilogramQuantity 2.4
+someFunc = print $ KilogramQuantity 2.4
diff --git a/src/OrderTakingDomain.hs b/src/OrderTakingDomain.hs
@@ -113,26 +113,27 @@ data Contact = Contact {
 
 findOrderLine :: NonEmpty OrderLine -> OrderLineId -> Maybe OrderLine
 findOrderLine orderLines olId =
-  L.find (\ol -> (orderLineId ol) == olId) orderLines 
+  L.find (\ol -> orderLineId ol == olId) orderLines 
 
 replaceOrderLine :: NonEmpty OrderLine -> OrderLineId -> OrderLine -> NonEmpty OrderLine
 -- TODO optimize
 replaceOrderLine orderLines oldId newOrderLine = 
-  map (\ol -> if ((orderLineId ol) == oldId) then newOrderLine else ol) orderLines
+  map (\ol -> if orderLineId ol == oldId then newOrderLine else ol) orderLines
 
 changeOrderPrice :: Order -> OrderLineId -> Price -> Maybe Order
 changeOrderPrice order orderLineId newPrice =
   let 
     orderLine = findOrderLine (lines order) orderLineId
+
     newOrderLine = (\ol -> ol { price = newPrice }) <$> orderLine
-    newOrderLines = (\nol -> replaceOrderLine (lines order) orderLineId nol) <$> newOrderLine
+    newOrderLines = replaceOrderLine (lines order) orderLineId <$> newOrderLine
   in 
     (\nols -> order { lines = nols }) <$> newOrderLines
 
 printQuantity qt =
   case qt of
-    UnitQuantity q -> putStrLn $ show q
-    KilogramQuantity q -> putStrLn $ show q
+    UnitQuantity q -> print q
+    KilogramQuantity q -> print q
 
 printList :: Show a => [a] -> String
 printList list =