Proposed change to libstatgrab/network_stats.c

[tdb]

This is taken from an old 2008 RT ticket. @rehsack wanted it preserved for further investigation. Here's the original message:

Hello, I observed the information about link status for Solaris Ethernet interfaces does not appear in the same place in kstat structure.

For "hme" and "ce" device drivers it appears in the driver instance information:
module=ce, instance=0, name=ce0, class=net
module=hme, instance=0, name=hme0, class=net

For "bge" device driver it appears in
module=bge, instance=0, name=mii, class=net

For "e1000g" device driver it appears in
module=e1000g, instance=0, name=statistics, class=net

The "patch" updates the queries on kstat structure at least for these device drivers.

And here is the patch given:

--- old-network_stats.c 2008-05-22 08:27:33.000000000 +0100
+++ network_stats.c 2008-05-22 08:57:57.000000000 +0100
@@ -697,9 +697,26 @@
                return NULL;
            }
 
-           if ((ifr.ifr_flags & IFF_UP) != 0) {
-               if ((knp = kstat_data_lookup(ksp, "link_up")) != NULL) {
-                   /* take in to account if link
+                        if ((ifr.ifr_flags & IFF_UP) != 0) {
+                            /* module=ce,  instance=0, name=ce0,  class=net 
+                               module=hme, instance=0, name=hme0, class=net */
+                            if ((knp = kstat_data_lookup(ksp, "link_up")) == NULL) { 
+                                /* module=bge, instance=0, name=mii, class=net */
+                                kstat_t *mksp = kstat_lookup(kc,ksp->ks_module,ksp->ks_instance,"mii");
+                                if (mksp != NULL) { 
+                                    knp = kstat_data_lookup(mksp,"link_up"); 
+                                    if (knp == NULL) { 
+                                        /* module=e1000g, instance=0, name=statistics, class=net */
+                                        mksp = kstat_lookup(kc,ksp->ks_module,ksp->ks_instance,"statistics"); 
+                                        if (mksp != NULL) { 
+                                            knp = kstat_data_lookup(mksp,"link_up"); 
+                                        }
+                                    }
+                                } 
+                           }
+
+                           if (knp != NULL) {
+                               /* take in to account if link
                     * is up as well as interface */
                    if (knp->value.ui32 != 0u) {
                        network_iface_stat_ptr->up = 1;

That patch was against libstatgrab 0.16.

[tdb]

#99 merged.