Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatter issue #20

Merged
merged 24 commits into from
Apr 20, 2019
Merged

Fix formatter issue #20

merged 24 commits into from
Apr 20, 2019

Conversation

i05nagai
Copy link
Owner

@i05nagai i05nagai commented Apr 13, 2019

clang-format formats code differently depending on its version. That causes inconsistent results between the local environment and Travis CI. Here we add a docker image for clang-format and remove the validity check on OSX of Travis CI.

Changes

  • We remove the script to check code format on OSX.
    • Behavior of clang-format depends on its version. On OSX with brew, it's a bit difficult to control the version of installed packages. In addition to that, we provide a docker image for formatting code which runs on Linux
  • Install buildifier and enable checking Bazel code in Travis CI

@coveralls
Copy link

coveralls commented Apr 19, 2019

Pull Request Test Coverage Report for Build 163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.766%

Totals Coverage Status
Change from base Build 127: 0.0%
Covered Lines: 561
Relevant Lines: 632

💛 - Coveralls

@i05nagai i05nagai changed the title [WIP]Fix formatter issue Fix formatter issue Apr 20, 2019
Copy link
Collaborator

@ktpr1223214 ktpr1223214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./tools/docker/gcc/docker_build_ubuntu1604.sh
./tools/docker_run_formatter.sh

I run these commands on local machine, and they seem to work quite well. Thanks for fixing this issue.
LGTM!

@i05nagai
Copy link
Owner Author

Thanks for the confirmation 😃

@i05nagai i05nagai merged commit 02d4a2a into master Apr 20, 2019
@i05nagai i05nagai deleted the fix-19-formatter-issue branch April 20, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants