-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatter issue #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use local variables instead of global
Travis CI provides pre-installed golang. It conflicts with new version
ktpr1223214
approved these changes
Apr 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./tools/docker/gcc/docker_build_ubuntu1604.sh
./tools/docker_run_formatter.sh
I run these commands on local machine, and they seem to work quite well. Thanks for fixing this issue.
LGTM!
Thanks for the confirmation 😃 |
This was referenced Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format
formats code differently depending on its version. That causes inconsistent results between the local environment and Travis CI. Here we add a docker image forclang-format
and remove the validity check on OSX of Travis CI.Changes
clang-format
depends on its version. On OSX withbrew
, it's a bit difficult to control the version of installed packages. In addition to that, we provide a docker image for formatting code which runs on Linux