Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect concatenated strings #38

Closed
ffigiel opened this issue Feb 26, 2016 · 7 comments
Closed

Collect concatenated strings #38

ffigiel opened this issue Feb 26, 2016 · 7 comments

Comments

@ffigiel
Copy link

ffigiel commented Feb 26, 2016

i18next-parser doesnt collect concatenated strings, e.g. i18n.t("Foo: " + "Bar"). It would be awesome if it did.
i18n-extract does this, so maybe it won't be difficult to reimplement?

@ffigiel
Copy link
Author

ffigiel commented Feb 27, 2016

I tried to port it and some of the tests pass, but most of them fail as babel raises syntax errors (e.g. invalid jsx). Also there's a problem with html and other templates, I'm not sure if babel can handle that

@karellm
Copy link
Member

karellm commented Feb 28, 2016

Do you actually need that? If so what is the use case?

@ffigiel
Copy link
Author

ffigiel commented Feb 29, 2016

The use case is breaking very long strings into a few lines for readability

@ffigiel
Copy link
Author

ffigiel commented Feb 29, 2016

Although I don't really need that, because I decided to go back to using i18n-extract, since the problem I had with it turned out to be a simple change. Sorry for making a mess here

@scags9876
Copy link

+1 We have the same issue... it would be great if i18next-parser could handle concatenated strings.

@karellm
Copy link
Member

karellm commented May 3, 2016

@scags9876 I'm maintaining this project for bugs but don't plan to add features to it. I will review a PR with documentation and test and publish a new version though.

@karellm
Copy link
Member

karellm commented Jan 30, 2018

I'm currently working on a big update for this project. This will be supported in 1.0. You can follow the progress at #72 and see the test case here

I'm closing this issue, if you have question please have them on the PR regarding 1.0

@karellm karellm closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants