-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0.0 #72
Conversation
59f009c
to
6116197
Compare
Since you rewrite many things, take a look at prettier. It's a great tool to clean up code. Just add |
@birdy- thanks I will definitely look at it. My code style changed quite a bit in the last 4 years, every time I had to maintain that code base was an humbling moment 😄 The new structure will hopefully make that a lot more pleasant. As to opinionated code styles, they make sense until they don't and then get in the way. That said I definitely should configure a linter of sort for collaborators to know what rules to follow. |
I have a suggestion: generating JS files (e.g {
// Extracted from file src/utils/Colors.js
"Red": "Rouge",
"Orange": "Orange",
"Yellow": "Jaune",
"Green": "Vert",
"Blue": "Bleu",
"Indigo": "Indigo",
"Violet": "Violet",
// Extracted from file src/utils/Languages.js
"English": "Anglais",
"French": "Français",
// Extracted from file src/SignUpForm.js
"First Name": "Prénom",
"Last Name": "Nom de famille",
"Email": "Email"
} It's nice for the translator to have the "context", like gettext's PO files: #: lib/error.c:116
msgid "Unknown system error"
msgstr "Error desconegut del sistema" |
Prettier will format code with few option (max length of a line, simple/double quote, ...). It's great because you don't have to do it manually. If you need help or you want me to setup it, I can do it. |
2b291f2
to
c3667e2
Compare
32bada6
to
c7e3fa3
Compare
ea8f308
to
e1c97ee
Compare
It's almost there. |
@birdy- I won'd use prettier because it transforms:
into
which makes absolutely no sense to me. |
:D |
Well there is something more important than rigidity. It's consistency, readability and actual productivity while coding. Prettier doesn't score well in the last 2 for me. |
Roadmap for the release:
vinyl-fs
gulp-util
Roadmap post release:
useKeyAsDefaultValue
Other
Prettier