Remove VueLexer #1007
Merged
Remove VueLexer #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/vue-template-compiler@2.7.16 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 95.16% 95.32% +0.16%
==========================================
Files 11 10 -1
Lines 1922 1905 -17
==========================================
- Hits 1829 1816 -13
+ Misses 93 89 -4 ☔ View full report in Codecov by Sentry. |
|
Thank you! It is now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
While investigating how to run i18next-parser on a vue3 code base, I came across this ticket which suggested simply removing
VueLexer, which would also eliminate the dependency issues withvue-template:#617
After trying it, this change seemed to meet my needs very nicely, so I thought I would contribute it back to make things easier for other folks using Vue3 (and dropping support for Vue2 didn't seem like it would be a very surprising change going forward).
In addition to removing VueLexer from the code (and its tests) I also updated the documentation and bumped the version to 9.0 since this is a breaking change. The migration documentation is updated to reflect that you need to remove
VueLexerfrom any configuration files as well.Let me know if you have any concerns/questions with this approach. Thanks!
Does it fix an existing ticket?
Yes #617
Checklist
yarn test(see details here)