custom contextSeparator fix #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vseva
force-pushed
the
customContextSeparator
branch
from
433d0ef
to
168c8d5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 95.16% 95.40% +0.24%
==========================================
Files 11 11
Lines 1922 1937 +15
==========================================
+ Hits 1829 1848 +19
+ Misses 93 89 -4 ☔ View full report in Codecov by Sentry. |
|
@karellm please look at this PR |
|
Thank you! It is now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
Unused keys where words separated with underscore (for example "some_key", "some_key_just_started_like_previous") not removed because _ hardcoded in helpers.js contextRegex and both "some_key" and "some_key_just_started_like_previous" treats like context forms of one key.
Does it fix an existing ticket?
No
Checklist
yarn test(see details here)