Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing componentFunctions properties to JsxLexerConfig types #891

Merged

Conversation

RobHannay
Copy link
Contributor

@RobHannay RobHannay commented Aug 22, 2023

Why am I submitting this PR

The componentFunctions property is missing from the parser type, though is documented here.

Does it fix an existing ticket?

Yes, #842.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • tests are included and pass: yarn test (see details here)
  • documentation is changed or added (N/A - documentation already correct)

@RobHannay RobHannay marked this pull request as ready for review August 22, 2023 08:44
@nicegamer7
Copy link
Contributor

Closes #842.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (5fdd776) 93.95% compared to head (e72f675) 93.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files          11       11           
  Lines        1836     1836           
=======================================
  Hits         1725     1725           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karellm karellm merged commit 1f06cf0 into i18next:master Aug 23, 2023
7 checks passed
@karellm
Copy link
Member

karellm commented Aug 23, 2023

Thanks! Deployed as 8.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants