Fix plural with variables #29

difelice · 2016-05-02T17:14:36Z

Fix Lint errors and warnings when running npm install
Fix plurals using variables not working

coveralls · 2016-05-02T17:22:09Z

Coverage increased (+0.04%) to 89.516% when pulling 023e706 on difelice:fix-plural-with-variables into d124aa4 on i18next:master.

coveralls · 2016-05-02T17:28:31Z

Coverage increased (+0.04%) to 89.516% when pulling 023e706 on difelice:fix-plural-with-variables into d124aa4 on i18next:master.

difelice · 2016-05-03T02:32:18Z

Thank you!

cheton · 2016-05-03T02:42:12Z

src/parser.js

@@ -246,7 +246,7 @@ class Parser {

                props.forEach((prop) => {
                    if (_.includes(supportedOptions, prop.key.name)) {
-                        options[prop.key.name] = prop.value.value;
+                        options[prop.key.name] = prop.value.value || prop.value.name;


In case of other scenarios we didn't think of, how about changing it into this?

options[prop.key.name] = prop.value;

cheton · 2016-05-03T03:46:39Z

Thanks for your PR. I just made some minor changes with v1.2.1 release.

adifelice-godaddy added 3 commits May 2, 2016 11:59

Fix lint warnings and errors

4a76e27

Fix plural with variables use case

db0db0e

Rename wrong test key on plural fixture

023e706

cheton merged commit caf57c9 into i18next:master May 3, 2016

cheton reviewed May 3, 2016
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix plural with variables #29

Fix plural with variables #29

difelice commented May 2, 2016

coveralls commented May 2, 2016 •

edited

coveralls commented May 2, 2016 •

edited

difelice commented May 3, 2016

cheton May 3, 2016

cheton commented May 3, 2016

Fix plural with variables #29

Fix plural with variables #29

Conversation

difelice commented May 2, 2016

coveralls commented May 2, 2016 • edited

coveralls commented May 2, 2016 • edited

difelice commented May 3, 2016

cheton May 3, 2016

Choose a reason for hiding this comment

cheton commented May 3, 2016

coveralls commented May 2, 2016 •

edited

coveralls commented May 2, 2016 •

edited