Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of HTML entities in JSX parsing #56

Merged
merged 2 commits into from Nov 16, 2017
Merged

Fix handling of HTML entities in JSX parsing #56

merged 2 commits into from Nov 16, 2017

Conversation

wichert
Copy link
Contributor

@wichert wichert commented Nov 16, 2017

htmlparser2 generates separate text nodes when parsing entities. To get the numbering correct for i18next we need to merge those in our AST tree.

Before this change Don&apos;t do this <strong>Dave</strong> was converted to Don't do this <3>Dave</3> instead of Don't do this <1>Dave</1>.

htmlparser2 generates separate text nodes when parsing entities. To get
the numbering correct for i18next we need to merge those in our AST
tree.
@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage increased (+0.1%) to 92.12% when pulling 1c4db38 on curvetips:html-entities into a87b3bc on i18next:master.

@cheton cheton merged commit 41979e0 into i18next:master Nov 16, 2017
@cheton
Copy link
Member

cheton commented Nov 16, 2017

Thank you. I will publish a new version by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants