Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Post missing resources" feature is not working #51

Closed
algiecas opened this issue Oct 23, 2012 · 5 comments
Closed

"Post missing resources" feature is not working #51

algiecas opened this issue Oct 23, 2012 · 5 comments

Comments

@algiecas
Copy link

It seems it never passes the actual data to post/get when sending missing resources. It only passes options.async while the data is in options.data

http[methode](options.url, {async: options.async}, function (status, data) {
    if (status === 200) {
        options.success(data.json(), status, null);
    } else {
        options.error(data.text(), status, null);
    }
});

Also the method always defaults to "GET" and it's not possible to change it in config as options.sendType is always undefined.

var methode = options.sendType ? options.sendType.toLowerCase() : 'get';

@jamuhl
Copy link
Member

jamuhl commented Oct 24, 2012

Sorry for the problems it caused you....this issue is already fixed in a prerelease version https://github.com/jamuhl/i18next/blob/master/release/i18next-1.5.8pre.js (which i have to get out as soon as possible).

@jamuhl
Copy link
Member

jamuhl commented Nov 2, 2012

v1.5.8 is out on http://i18next.com -> should be solved

@jamuhl jamuhl closed this as completed Nov 2, 2012
@algiecas
Copy link
Author

algiecas commented Jan 6, 2013

Unfortunately, it's still not working (using v1.5.10) - options.data (where the untranslated string resides) is not sent to the server.

@jamuhl
Copy link
Member

jamuhl commented Jan 7, 2013

Will have a look again...strange - should work.

@jamuhl jamuhl reopened this Jan 7, 2013
@jamuhl
Copy link
Member

jamuhl commented Feb 1, 2013

sorry you had to wait so long for a response. this will be fixed with next release v1.5.11 comming begin of february.

if you need this sooner just feel free to grap the v1.5.11pre version in the git repository.

@jamuhl jamuhl closed this as completed Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants