feat: Add public directory support #525
Conversation
…ecation of static directory
| @@ -20,4 +20,5 @@ const localeSubpathVariations = { | |||
| module.exports = new NextI18Next({ | |||
| otherLanguages: ['de'], | |||
| localeSubpaths: localeSubpathVariations[localeSubpaths], | |||
| localePath: typeof window === "undefined" ? "public/locales" : "static/locales", | |||
There was a problem hiding this comment.
This behaviour should be built in.
There was a problem hiding this comment.
it is a question or affirmation?
There was a problem hiding this comment.
An affirmation - it doesn't make sense to require all users to perform the same check.
| const fs = eval("require('fs')") | ||
| const path = require('path') | ||
| const hasStaticDir = fs.existsSync(path.join(process.cwd(), 'static')) |
There was a problem hiding this comment.
We should be checking if there are namespace files here, not just if the dir exists.
There was a problem hiding this comment.
Could it be on the same line or adding another validation?
There was a problem hiding this comment.
Sure, it could be another const called hasDefaultNamespace or something.
| const hasStaticDir = fs.existsSync(path.join(process.cwd(), 'static')) | ||
| const hasPublicDir = fs.existsSync(path.join(process.cwd(), 'public')) | ||
|
|
||
| let staticLegacy = 'static/locales' |
There was a problem hiding this comment.
This won't work. We need to respect the localePath in case a user has provided a non-default value.
There was a problem hiding this comment.
Correct, so we just add the warning and the localePath change?
There was a problem hiding this comment.
Not sure exactly what you mean.
|
@isaachinman These days I could send the PR update, but I see that there is an open PR. I have no problem updating or continuing with the new. |
|
Closing in favour of #569. |
close: #523
notes
Add support to the example for the tests to be successful