remove i18n check in provider

i18next · Nov 6, 2018 · 022b9aa · 022b9aa
1 parent 6375bab
commit 022b9aa
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 33 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### 8.3.6
+
+- remove componentWillReceiveProps call in I18nextProvider to comply with react strict mode [596](https://github.com/i18next/react-i18next/pull/596)
+
 ### 8.3.5
 
 - rename named export to window.ReactI18next for standalone js

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-i18next",
-  "version": "8.3.5",
+  "version": "8.3.6",
   "description": "Internationalization for react done right. Using the i18next i18n ecosystem.",
   "main": "dist/commonjs/index.js",
   "types": "index.d.ts",

diff --git a/react-i18next.js b/react-i18next.js
@@ -2574,12 +2574,6 @@
       initSSR(props, true);
     }
 
-    componentWillReceiveProps(nextProps) {
-      if (this.props.i18n !== nextProps.i18n) {
-        throw new Error('[react-i18next][I18nextProvider]does not support changing the i18n object.');
-      }
-    }
-
     render() {
       const _this$props = this.props,
             children = _this$props.children,

diff --git a/react-i18next.min.js b/react-i18next.min.js
diff --git a/src/I18nextProvider.js b/src/I18nextProvider.js
@@ -10,12 +10,6 @@ export class I18nextProvider extends Component {
     initSSR(props, true);
   }
 
-  componentWillReceiveProps(nextProps) {
-    if (this.props.i18n !== nextProps.i18n) {
-      throw new Error('[react-i18next][I18nextProvider]does not support changing the i18n object.');
-    }
-  }
-
   render() {
     const { children, i18n, defaultNS, reportNS } = this.props;
 

diff --git a/test/i18nextProvider.spec.js b/test/i18nextProvider.spec.js