Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Trans component to support react 18 types #1492

Merged
merged 2 commits into from May 5, 2022
Merged

Fix Trans component to support react 18 types #1492

merged 2 commits into from May 5, 2022

Conversation

pedrodurek
Copy link
Member

@pedrodurek pedrodurek commented Apr 28, 2022 •
edited

Closes #1490 and #1483

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@pedrodurek pedrodurek mentioned this pull request Apr 28, 2022
Closed
@adrai adrai mentioned this pull request May 2, 2022
Closed
@pedrodurek pedrodurek marked this pull request as ready for review May 5, 2022 04:18
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.951% when pulling 0db824f on pedrodurek:fix-trans-types-react-18 into 926cbac on i18next:master.

@adrai adrai merged commit 8ed568a into i18next:master May 5, 2022
@adrai
Copy link
Member

adrai commented May 5, 2022

included in v11.16.8

@cravend cravend mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React 18 - Trans component interpolation issue
3 participants
@pedrodurek @coveralls @adrai