Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU: Trans macro will parse defaults as alternate to children #917

Merged
merged 1 commit into from Aug 10, 2019
Merged

ICU: Trans macro will parse defaults as alternate to children #917

merged 1 commit into from Aug 10, 2019

Commits on Aug 9, 2019

  1. ICU: Trans macro will parse defaults as alternate to children 

    Fix for i18next/i18next#1295
Adds support for ICU message syntax inside the `defaults` attribute
This allows the Trans macro to be used with linters and other code analysis
tools that expect valid JSX syntax as children, by using the defaults
prop instead of children for the message.

Also adds support fo the `<SelectOrdinal>` tag
Fixes a bug where `Trans` was imported from 'react/i18next' instead of 'react-i18next'
    @redbugz
    redbugz committed Aug 9, 2019
    Copy the full SHA
    f732d93 View commit details
    Browse the repository at this point in the history