Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency of the focus-command when switching between containers #1160

Closed
i3bot opened this issue Jan 12, 2014 · 4 comments
Closed

Inconsistency of the focus-command when switching between containers #1160

i3bot opened this issue Jan 12, 2014 · 4 comments
Assignees
Labels
4.7 bug reproducible A bug that has been reviewed and confirmed by a project contributor

Comments

@i3bot
Copy link

i3bot commented Jan 12, 2014

[Originally reported by dpoi@…]
(On executing a focus-command, i3 selects the next window of the given direction. If there is a new container, i3 will focus to the ACTIVE window of this container - even if there is an unactive window between the focused window and the active window of the target container.
But if the target container is on another display, it happens, that the focus-command will focus the UNACTIVE window of the target container.

@i3bot
Copy link
Author

i3bot commented Jan 12, 2014

[Original comment by TonyC]

As far as I can tell, this issue only affects the command focus <direction> when switching between outputs.

@stapelberg
Copy link
Member

I find the description fairly confusing. dpoi, can you maybe attach pictures to illustrate what you mean? Ideally also a logfile. Thanks.

@i3bot
Copy link
Author

i3bot commented Jan 13, 2014

[Original comment by TonyC]

Replying to comment 2 @…:

I find the description fairly confusing. dpoi, can you maybe attach pictures to illustrate what you mean? Ideally also a logfile. Thanks.

The issue is we use con_descend_direction if the container in that direction is a workspace and con_descend_focused everywhere else, if that helps.

There is one way in which workspaces are different from normal containers, however, and that is that they can have floating containers. If we went the ordinary route there, switching outputs with focus <direction> may sometimes focus a floating container.

@stapelberg stapelberg removed the general label Feb 4, 2015
@Airblader Airblader added bug reproducible A bug that has been reviewed and confirmed by a project contributor labels May 30, 2015
@orestisfl
Copy link
Member

IMO it makes sense to allow to focus floating windows that where on the top of the focus head when switching workspaces with directional focus: orestisfl@4a920e4.

orestisfl added a commit to orestisfl/i3 that referenced this issue Sep 28, 2017
This way, when changing focus between outputs, the directional focus
command will focus the focused window within the parent container that
is next in the given direction.

Previously, the next window of the given direction was focused which is
Inconsistent with changing focus inside the same output.

Fixes i3#1160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.7 bug reproducible A bug that has been reviewed and confirmed by a project contributor
Projects
None yet
Development

No branches or pull requests

4 participants