Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description for the fullscreen_mode field received from IPC request 'GET_TREE'. #3780

Closed
Iskustvo opened this issue Aug 31, 2019 · 1 comment · Fixed by #3784
Closed

Description for the fullscreen_mode field received from IPC request 'GET_TREE'. #3780

Iskustvo opened this issue Aug 31, 2019 · 1 comment · Fixed by #3784

Comments

@Iskustvo
Copy link
Contributor

I'm submitting a…

[ ] Bug
[ ] Feature Request
[x] Documentation Request
[ ] Other (Please describe in detail)

Description

When requesting GET_TREE over the IPC, i3's response contains fields named fullscreen_mode.
I've got an reasonable PR for using these fields in my IPC library, but since it is not documented in the official documentation(at least not for GET_TREE), I have some concerns about it:

  1. Is fullscreen_mode field safe to use?
  2. Which nodes have this flag set to 1? (I've seen it set on some of i3's internal nodes)
  3. Will this field always have value or can it be null/unset?
  4. Can it have any value other than 0 and 1?

Version

Output of i3 --moreversion 2>&-:

Binary i3 version:  4.17.1 (2019-08-30) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.17.1 (2019-08-30) (pid 647) abort…)
@Airblader
Copy link
Member

Airblader commented Sep 1, 2019

Is fullscreen_mode field safe to use?

Yes.

Which nodes have this flag set to 1?

"1" means that the window is fullscreened on its output, "2" means it is globally fullscreened.

I've seen it set on some of i3's internal nodes

All workspaces are flagged as fullscreened on their output, and the scratchpad is just a (albeit special) workspace.

Will this field always have value or can it be null/unset?

It will always be set.

Can it have any value other than 0 and 1?

Yes, 2, see above. :-)


If someone wants to send a PR to document this here, we would appreciate it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants