Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building deb package fails w/ debuild #4136

Closed
laur89 opened this issue Jun 25, 2020 · 6 comments
Closed

building deb package fails w/ debuild #4136

laur89 opened this issue Jun 25, 2020 · 6 comments
Labels
bug missing-log Read the CONTRIBUTING.md file for instructions missing-version
Milestone

Comments

@laur89
Copy link

laur89 commented Jun 25, 2020

I'm submitting a…

[x] Bug
[ ] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

Building deb package using debuild after meson (actually unlikely it's the fault of a build tool change, only speculating here) was introduced fails on debian, see this gist for full log.
Tail end of the error:

make[1]: Entering directory '/tmp/i3'
dh_installchangelogs RELEASE-NOTES-*
make[1]: Leaving directory '/tmp/i3'
   dh_systemd_enable -O--buildsystem=meson
   dh_installinit -O--buildsystem=meson
   dh_systemd_start -O--buildsystem=meson
   dh_perl -O--buildsystem=meson
   dh_link -O--buildsystem=meson
   dh_installwm -O--buildsystem=meson
dh_installwm: error: no manpage found (creating an x-window-manager alternative requires a slave symlink for the manpage)
make: *** [debian/rules:30: binary] Error 25
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -b failed

Expected Behavior

Expecting running debuild -us -uc -b to produce a valid deb package, as used to be the case some months ago.

Reproduction Instructions

  • Clone the i3 repo
  • navigate to the cloned dir
  • make sure all the build deps are installed
  • run debuild -us -uc -b

Environment

i3 ver: 51b05835

- Linux Distribution & Version:
Linux WH5005264 5.6.0-2-amd64 #1 SMP Debian 5.6.14-1 (2020-05-23) x86_64 GNU/Linux
Debian testing (bullseye)

Bonus question:

How to modify the debian/rules file to configure for proper release build? Prior to meson, I applied this patch, ie adding --disable-sanitizers flag.
How to properly do this with meson? Would this be correct (ie adding --buildtype=release -Db_sanitize=none flags)?

@i3bot i3bot added bug missing-log Read the CONTRIBUTING.md file for instructions labels Jun 25, 2020
@i3bot
Copy link

i3bot commented Jun 25, 2020

I don’t see a link to logs.i3wm.org. Did you follow https://i3wm.org/docs/debugging.html? (In case you actually provided a link to a logfile, please ignore me.)

@i3bot
Copy link

i3bot commented Jun 25, 2020

I don’t see a version number. Could you please copy & paste the output of i3 --version into this issue?

@idnsunset
Copy link

Got the exactly same issue with dpkg-buildpackage command. I was just trying to build from the latest next branch, no changes were done to the debian/rules file, please advice how to get the build work?

@stapelberg stapelberg mentioned this issue Oct 28, 2020
7 tasks
@orestisfl orestisfl added this to the 4.19 milestone Oct 28, 2020
stapelberg added a commit to stapelberg/i3 that referenced this issue Oct 28, 2020
This fixes a build failure in dh_installwms.

fixes i3#4136
@stapelberg
Copy link
Member

See #4235 for the fix.

@laur89
Copy link
Author

laur89 commented Oct 28, 2020

Thanks, will give it a go!
Regarding the other Q, are these flags the way to go for disabling sanitizers in meson for release build?: --buildtype=release -Db_sanitize=none

@stapelberg
Copy link
Member

are these flags the way to go for disabling sanitizers in meson for release build?: --buildtype=release -Db_sanitize=none

looks right to me, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug missing-log Read the CONTRIBUTING.md file for instructions missing-version
Projects
None yet
Development

No branches or pull requests

5 participants