Layout toggle split not working.

[L0rdRoyce]

I'm submitting a…

[x] Bug
[ ] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

Pressing Win+e (layout toggle split) does not toggle layout once Win+v (split toggle) is pressed. It's working fine before Win+v is pressed on the window but as soon as Win+v is used on the window, Win+e stops working and instead works just like Win+v. So once win+v is pressed win+e starts behaving like win+v instead of doing what its supposed to do.

Expected Behavior

When Win+e is pressed the vertically split layout should change to horizontal split layout. When Win+v is pressed the indicator should toggle between vertical and horizontal positions. Win+e (layout toggle split) should not depend on whether Win+v (split toggle) has been pressed or not.

Reproduction Instructions

Open 2 windows. Press Win+e (layout toggle split) and it should work. Now press Win+v (split toggle) while focus is on the left window. Further pressing Win+e doesn't work. Now focus on the right window. Press Win+e and it should work. Now press Win+v and any further Win+e deos not work in either window. Opening new windows and focusing on them enables Win+e but again if Win+v is pressed then Win+e stops working.

Environment

Output of i3 --moreversion 2>&-:

i3 version: 4.22 (2023-01-02)

Config file

Config Url: https://pastebin.com/pauWfSSz

- Linux Distribution & Version: Arch Linux
- Are you using a compositor (e.g., xcompmgr or compton): picom

[i3bot]

I don’t see a link to logs.i3wm.org. Did you follow https://i3wm.org/docs/debugging.html? (In case you actually provided a link to a logfile, please ignore me.)

[slyshot]

The cause of this seems to be that split toggle creates a container around your window, and layout toggle split changes the layout of /that/ container. I'd like someone who knows about the project's design and philosophy to give some input on whether this should stay that way, or if this is an actual bug before I try and implement a fix and pull request.
The solution seems fairly simple; have layout split toggle keep ascending until it finds a container with more than one window. If it finds none, then we can either have it do nothing or do what it currently does.

[orestisfl]

The cause of this seems to be that split toggle creates a container around your window, and layout toggle split changes the layout of /that/ container. I'd like someone who knows about the project's design and philosophy to give some input on whether this should stay that way, or if this is an actual bug before I try and implement a fix and pull request. The solution seems fairly simple; have layout split toggle keep ascending until it finds a container with more than one window. If it finds none, then we can either have it do nothing or do what it currently does.

Correct, sounds like this works as expected