Move resolve_tilde and get_config_path into libi3 #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (res == GLOB_NOMATCH || globbuf.gl_pathc != 1) | ||
| result = sstrdup(path); | ||
| else if (res != 0) { | ||
| err(1, "glob() failed"); |
|
Looks good overall. |
stapelberg
added
the
waiting
|
Fixed and rebased on next. |
stapelberg
added a commit
that referenced
this pull request
Mar 29, 2015
Move resolve_tilde and get_config_path into libi3
orestisfl
removed
the
waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is groundwork for a reworked version of #1588.
I pulled the "Unable to find the configuration file" die() call out of get_config_path because it seems bad to have that function return NULL on error in one instance, yet call die() in another.