Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3-dmenu-desktop: Remove quotes around exec cmd #2265

Closed
wants to merge 1 commit into from

Conversation

mikkeloscar
Copy link

The reason for this patch is discussed more in depth here: swaywm/sway#521

The real issue is that the exec command in i3 doesn't treat quoted arguments the same way as other commands do. For instance exec "firefox " http://google.com is the same as exec firefox http://google.com in i3. This is an unfortunate design, but something that most likely won't change because of backwards compatibility.

Sway aims to be compatible with i3, but we would like to avoid implementing this behavior if it doesn't break too much for the users.

This patch solves some of the issue by making i3-dmenu-desktop compatible with sway, without affecting how it works with i3.

This patch removes the unesseary quotes in the i3-msg exec call.
@stapelberg
Copy link
Member

I don’t follow the discussion in the referenced issue (might be because I’m tired from jet lag). Could you do me and other readers of this commit a favor and document the rationale for this commit in the commit description itself please? Currently it just says that the quotes are unnecessary but doesn’t expand on this. Why are they unnecessary? What’s broken currently? With this change, what could break because of the change?

@mikkeloscar
Copy link
Author

I have realized that this won't work for some edge cases in i3, so I'll close it again. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants