i3-dmenu-desktop: Remove quotes around exec cmd #2265
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this patch is discussed more in depth here: swaywm/sway#521
The real issue is that the
exec
command in i3 doesn't treat quoted arguments the same way as other commands do. For instanceexec "firefox " http://google.com
is the same asexec firefox http://google.com
in i3. This is an unfortunate design, but something that most likely won't change because of backwards compatibility.Sway aims to be compatible with i3, but we would like to avoid implementing this behavior if it doesn't break too much for the users.
This patch solves some of the issue by making
i3-dmenu-desktop
compatible with sway, without affecting how it works with i3.