_NET_ACTIVE_WINDOW: invalidate focus to force SetInputFocus call #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sender of the _NET_ACTIVE_WINDOW client message might know better when to set focus than i3, as i3 does not know about unmanaged (override_redirect=1) windows. related to i3/i3lock#35
stapelberg
added a commit
to stapelberg/i3lock
that referenced
this pull request
Oct 22, 2017
When grabbing the pointer/keyboard fails, a new code path is activated, which: 1. Uses the standards-compliant _NET_ACTIVE_WINDOW root window property to determine the window to restore focus to. 2. Sets the input focus to the i3lock window, effectively force-closing any open context menus (tested with Google Chrome). 3. Upon exiting, restores focus to the window from step ① by sending a _NET_ACTIVE_WINDOW ClientMessage to the root window. Note that this step requires i3/i3#3027 in i3 to not mess up focus. fixes i3#35
|
I don't understand this change. This path is never reached for unmanaged windows? |
|
Correct, and it doesn’t need to be. In i3lock, we’re using the _NET_ACTIVE_WINDOW ClientMessage on the managed window which had focus before i3lock took it. Without this change, though, i3 won’t send a SetInputFocus request, because it didn’t notice the focus changes by the unmanaged window. |
|
IMHO we are supporting broken client behavior with this change, just that in this case the broken client is i3lock. The reason we need this change is because the client caused us to be out of sync. Wouldn't a correct fix to avoid running out of sync, e.g., by processing FocusOut events? Openbox seems to do this, but unfortunately it is rather involved since one has to coordinate with FocusIn events. But I think I've already lost the argument that we are turning i3lock into a broken client, so let's move on. At the very least the one positive thing about this change is that it's a safety net for when the request originates not from the broken client, but somewhere else. |
Airblader
approved these changes
Oct 22, 2017
stapelberg
added a commit
to stapelberg/i3lock
that referenced
this pull request
Oct 22, 2017
When grabbing the pointer/keyboard fails, a new code path is activated, which: 1. Uses the standards-compliant _NET_ACTIVE_WINDOW root window property to determine the window to restore focus to. 2. Sets the input focus to the i3lock window, effectively force-closing any open context menus (tested with Google Chrome). 3. Upon exiting, restores focus to the window from step ① by sending a _NET_ACTIVE_WINDOW ClientMessage to the root window. Note that this step requires i3/i3#3027 in i3 to not mess up focus. fixes i3#35
|
IIUC, maintaining sync would result in 1 fewer force-focus at the expense of more complicated code paths. If it turns out that this 1 force-focus is a problem, we can always switch to the maintain-sync approach :). |
stapelberg
added a commit
to stapelberg/i3lock
that referenced
this pull request
Oct 22, 2017
When grabbing the pointer/keyboard fails, a new code path is activated, which: 1. Uses the standards-compliant _NET_ACTIVE_WINDOW root window property to determine the window to restore focus to. 2. Sets the input focus to the i3lock window, effectively force-closing any open context menus (tested with Google Chrome). 3. Upon exiting, restores focus to the window from step ① by sending a _NET_ACTIVE_WINDOW ClientMessage to the root window. Note that this step requires i3/i3#3027 in i3 to not mess up focus. fixes i3#35
stapelberg
added a commit
to stapelberg/i3lock
that referenced
this pull request
Oct 22, 2017
When grabbing the pointer/keyboard fails, a new code path is activated, which: 1. Uses the standards-compliant _NET_ACTIVE_WINDOW root window property to determine the window to restore focus to. 2. Sets the input focus to the i3lock window, thereby possibly force-closing open context menus (works with e.g. Google Chrome, does not work with e.g. thunar, gedit). 3. Upon exiting, restores focus to the window from step ① by sending a _NET_ACTIVE_WINDOW ClientMessage to the root window. Note that this step requires i3/i3#3027 in i3 to not mess up focus. fixes i3#35
stapelberg
added a commit
to i3/i3lock
that referenced
this pull request
Oct 22, 2017
When grabbing the pointer/keyboard fails, a new code path is activated, which: 1. Uses the standards-compliant _NET_ACTIVE_WINDOW root window property to determine the window to restore focus to. 2. Sets the input focus to the i3lock window, thereby possibly force-closing open context menus (works with e.g. Google Chrome, does not work with e.g. thunar, gedit). 3. Upon exiting, restores focus to the window from step ① by sending a _NET_ACTIVE_WINDOW ClientMessage to the root window. Note that this step requires i3/i3#3027 in i3 to not mess up focus. fixes #35
Hedroed
pushed a commit
to Hedroed/i3lock
that referenced
this pull request
Nov 23, 2021
When grabbing the pointer/keyboard fails, a new code path is activated, which: 1. Uses the standards-compliant _NET_ACTIVE_WINDOW root window property to determine the window to restore focus to. 2. Sets the input focus to the i3lock window, thereby possibly force-closing open context menus (works with e.g. Google Chrome, does not work with e.g. thunar, gedit). 3. Upon exiting, restores focus to the window from step ① by sending a _NET_ACTIVE_WINDOW ClientMessage to the root window. Note that this step requires i3/i3#3027 in i3 to not mess up focus. fixes i3#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sender of the _NET_ACTIVE_WINDOW client message might know better when to
set focus than i3, as i3 does not know about unmanaged (override_redirect=1)
windows.
related to i3/i3lock#35