create_workspace_on_output: send workspace init event #3632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orestisfl
force-pushed
the
workspace_init
branch
from
eddc157
to
f4a7bac
Compare
|
Added some tests |
Fixes i3#3595 Like the issue mentions: > instead of the newly created workspace (not referenced by variable > here) the `"init"` event is fired with the current workspace (`ws`). Plus, there was another issue where duplicate workspace init events where being sent because of workspace_get(). 304-ipc-workspace-init.t: Subtest "move workspace to output" fails with current next. Fixes i3#3631 No event was being sent here: https://github.com/i3/i3/blob/2d6e09a66ad9b3e01588c515ae66476de8903754/src/randr.c#L487 533-randr15.t: I confirmed that SKIP still works if the xrandr command fails. Added test fails with current next.
orestisfl
force-pushed
the
workspace_init
branch
from
f4a7bac
to
098b0e6
Compare
Airblader
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3595
Fixes #3631
Didn't test it much yet, can do it tomorrow.