-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds surface
focusing mode
#3859
Conversation
cmd_focus_direction
to contain sibling
and new mode: lazy
I'm a bit constrained on time and I think @orestisfl understands this code the best at the moment anyway, perhaps he can take a look and help you further on this for now. My only comment right now is that we'll need to squash the commits into one proper commit in the end, but of course there's many other things to be done as well (userguide, tests). :-) I'm not yet sure about the "lazy" (for the record, I dislike "estranged" even more). We should try to think of a more descriptive name. |
And I just did my 1st github squash ever 😀. I don't know for sure, but by the looks of it, my heart says that something is not right. |
Yeah, it is definitely not correct at the moment. :-/ |
Fixed commit. Now my PR looks as if I always was a very smart guy. I guess the trick is to always forcefully push lies to my github fork? I.e. 1st rewrite history to look smart, then push such lie by |
Yes, squashing rewrites the history of your feature branch and therefore requires rewriting the history. :-) |
cmd_focus_direction
to contain sibling
and new mode: lazy
surface
focusing mode
now i no longer touch the implementation of
o, and, instead of calling the new mode synopsis: this feature will allow navigating throughout stacked/tabbed/normal windows without getting stuck in tab/stack swamps (more info on this in #3738), without even needing a neat side effect: once coupled with |
I'm OK with the complexity of the change, but haven't reviewed it yet. I'm not too happy with the naming yet, though. To be continued. :) |
how about |
Closing this PR as the author is banned from all i3 community spaces after interactions such as (but not limited to) https://www.freelists.org/post/i3-discuss/squigz-abusing-op-power-in-i3-i3offtopic |
usability problem [fixes i3/i3#3859].
usability problem [fixes i3/i3#3859].
usability problem [fixes i3/i3#3859].
usability problem [fixes i3/i3#3859].
Fixes #3738