Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating redundant containers when switching between tabbed/stacked and split layouts #5469

Merged
merged 1 commit into from Jan 31, 2024

Conversation

orestisfl
Copy link
Member

Fixes #3001

@stapelberg
Copy link
Member

I don’t have time to look at this in detail right now, but can you outline why tree_flatten in src/tree.c is not sufficient? I would have expected a fix to land there.

@orestisfl
Copy link
Member Author

I don't think single-parent containers are inherently bad that's why it's hard to find a general rule that would fix the issue and keep tree_flatten's behavior acceptable in all cases where it's called.

@orestisfl orestisfl self-assigned this Dec 13, 2023
@orestisfl
Copy link
Member Author

@stapelberg Any chance we re-visit this PR? I feel it's one of the major causes of pain for users. I think including a fix in tree_flatten is not the way to go. The function cannot always be called except for "cleanup" operations after moves etc and I feel that it is much cleaner to prevent creating a situation rather than fixing it afterwards.

@stapelberg
Copy link
Member

OK, I’ll try to take another look in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split + layout stacked / tabbed creates redundant containers
2 participants