Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Show locking state #36

Closed
Airblader opened this issue Sep 21, 2015 · 2 comments · Fixed by #88
Closed

[enhancement] Show locking state #36

Airblader opened this issue Sep 21, 2015 · 2 comments · Fixed by #88

Comments

@Airblader
Copy link
Member

See #35. i3lock should display "locking..." while it is trying to grab the pointer so the user knows when the locking was successful.

@stapelberg
Copy link
Member

Note that we should only start displaying that text after a little delay, maybe 250ms, so that in regular operations, people won’t see it (only if the operation is about to fail).

@stapelberg
Copy link
Member

Also note how we need to pay attention to forking: we should only fork when we could grab the pointer/keyboard, and the exit code still needs to be 0/1 according to success/failure of grabbing.

…otherwise, we might break the security of people’s suspend mechanism, i.e. people who use i3lock && pm-suspend would end up with a non-locked screen.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants