add format_quality option in wireless #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airblader
requested changes
Jun 29, 2018
man/i3status.man
Outdated
| @@ -300,7 +300,8 @@ There also is an option "format_down". You can hide the output with | |||
|
|
|||
| Gets the link quality, frequency and ESSID of the given wireless network | |||
| interface. You can specify different format strings for the network being | |||
| connected or not connected. | |||
| connected or not connected.The quality is padded with leading zeroes by | |||
There was a problem hiding this comment.
There should be a space after the period.
man/i3status.man
Outdated
| @@ -300,7 +300,8 @@ There also is an option "format_down". You can hide the output with | |||
|
|
|||
| Gets the link quality, frequency and ESSID of the given wireless network | |||
| interface. You can specify different format strings for the network being | |||
| connected or not connected. | |||
| connected or not connected.The quality is padded with leading zeroes by | |||
| default; to pad with something else use +format_quality=" "+. | |||
There was a problem hiding this comment.
I think this should just be
[…] use +format_quality+.
Stunkymonkey
force-pushed
the
format_quality
branch
from
fb6d17b
to
4ea804b
Compare
|
fixed your requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #25