Update min python to 3.9 and min sunpy to 4 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
samaloney
commented
Feb 10, 2023
•
samaloney
commented
- Update various conflicts and deps for python 3.9
- Update azure, githubaction and readthedocs
Codecov ReportBase: 81.04% // Head: 81.02% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
==========================================
- Coverage 81.04% 81.02% -0.02%
==========================================
Files 63 63
Lines 6314 6473 +159
==========================================
+ Hits 5117 5245 +128
- Misses 1197 1228 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
samaloney
force-pushed
the
feat-bump-python38
branch
from
c9663d7
to
ca3ebf9
Compare
samaloney
force-pushed
the
feat-bump-python38
branch
from
692dbd8
to
19d8f6f
Compare
samaloney
changed the title
samaloney
commented
Feb 10, 2023
| assert np.allclose(transmission, hydrogen.transmission([1e-3, 1e-1, 1e+1] * u.MeV)) | ||
|
|
||
|
|
||
| @pytest.mark.skip('Changes to transmission data') |
There was a problem hiding this comment.
Need to investigate the change of transmission values.
nicHoch
approved these changes
Feb 10, 2023
nicHoch
pushed a commit
to nicHoch/STIXCore
that referenced
this pull request
Feb 21, 2023
* Update min python to 3.9 and min sunpy to 4.0 * Update python version for RTD, fix for upated roentgen * Update python version in github action * Fix rtd issue with python3.9 * Update code to use newer release of roentgen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.