Backoffice contribution credit card form unable to update the billing block

[monishdeb]

Overview

Steps to replicate:

1. Install and enable iATS paymentextension
2. Add and configure an iATS Payments ACH/EFT payment type payment processor.
3. Enable USD and CAD currencies
4. Go to 'Submit Credit Card Contribution' backoffice form
5. Choose payment processor created at step 2

Issue:

1. Payment block renders payment block without check template
2. Switching currency doesn't update the payment block.

Before

After

ping @adixon @eileenmcnaughton @KarinG

[adixon]

Ah, very nice, thanks for this. Might even be in time for our next release that's due out shortly.

Especially like the animated gifs!

[monishdeb]

Thanks @adixon I have just now pushed additional fixes and updated the AFTER screencast, to provide a glimpse of how the CC backoffice form is behaving now.

[KarinG]

Great @monishdeb 👍

@adixon - note there is a companion PR for Core (by Monish) that will need to be merged to make this work.

[KarinG]

@adixon - this is the core PR -> civicrm/civicrm-core#18517

[monishdeb]

@adixon @KarinG I think this PR can be merged as earlier it was depending on core PR civicrm/civicrm-core#18517 which got merged in Civi 5.35.

[KarinG]

Ah right - it was the issue where I suggested that the "SUBMIT CREDIT CARD CONTRIBUTION" button really should be relabeled if it would now also allow people to submit "ACH/EFT" but I was overruled 🙂