Remove tests I know... - but they will be elsewhere. #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seamuslee001
added a commit
to seamuslee001/com.iatspayments.civicrm
that referenced
this pull request
Oct 20, 2023
|
It's always good to reduce unnecessary noise and friction, but my hesitation is - isn't more testing better? Isn't it worth fixing instead of removing completely? I'll admit upfront that I'm the poster bad boy of not testing, so if your answer is: "you fix it", I can hear that ... In terms of the link you posted, it seems like Dave already fixed that specific issue here: 6a721e9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alan -> see:
civicrm/civicrm-core#27811