Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grayscale with Alpha 9patch PNGs decoding brightens #1508

Closed
phhusson opened this issue May 20, 2017 · 2 comments
Closed

Grayscale with Alpha 9patch PNGs decoding brightens #1508

phhusson opened this issue May 20, 2017 · 2 comments

Comments

@phhusson
Copy link
Contributor

Here are the samples:
This is the original 9.png from AOSP (btn_zoom_up_normal.9.png):
https://drive.google.com/file/d/0B5fQwPNvh3h0T3JhT041N2N6SDQ/view?usp=sharing

This is the 9.png as extracted by apktool:
https://drive.google.com/file/d/0B5fQwPNvh3h0dlI1VGwtd2J2NEE/view?usp=sharing

This is the 9.png extracted from framework-res with unzip:
https://drive.google.com/file/d/0B5fQwPNvh3h0NXJ0cnFGWTAwNnM/view?usp=sharing

Related issues and PR: #1182 #1180 #437
Related commits:
ae6f808
63b0dd1
@phhusson
Copy link
Contributor Author

Issue still happens on openjdk 9b170
https://bugs.openjdk.java.net/browse/JDK-5051418 is not clear whether this has been fixed in current jdk9, though it is supposed to be fixed before the release.

@phhusson
Copy link
Contributor Author

Erm, actually the jdk bug has been closed with won't fix...

phhusson added a commit to phhusson/Apktool that referenced this issue May 20, 2017
@phhusson
In case of a grayscale + alpha 9patch, work-around JDK.
649716a 
Original code:
https://worldwind31.arc.nasa.gov/svn/trunk/WorldWind/src/gov/nasa/worldwind/util/gdal/GDALUtils.java
/JDK-5051418
Cf Bug iBotPeaches#1508
@phhusson phhusson mentioned this issue May 20, 2017
Merged
phhusson added a commit to phhusson/Apktool that referenced this issue May 20, 2017
@phhusson
In case of a grayscale + alpha 9patch, work-around JDK.
dd32f94 
Original code:
https://worldwind31.arc.nasa.gov/svn/trunk/WorldWind/src/gov/nasa/worldwind/util/gdal/GDALUtils.java
/JDK-5051418
Cf Bug iBotPeaches#1508
iBotPeaches added a commit that referenced this issue May 25, 2017
@iBotPeaches
Add unit-test for #1508
c3ea300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phhusson