Adds doNotCompress list to apktool.yml #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the list of files (resources, assets, etc) that are stored in the .apk uncompressed. For apps that use AssetFileDescriptor.openFd(), the adding compression will break the call. Maintains support for the resourcesAreCompressed key, but no longer records it when decompiling (it instead records resources.arsc in the doNotCompress list).
|
This looks amazing. Thanks for making a clear and easy PR to review, and thanks a ton for maintaining previous support. Code looks great, ran it on a few apks, but will need to make a quick example apk (mainly so I can understand the failure vs verifying your change) then I'll merge this in. |
|
Awesome! |
iBotPeaches
added a commit
that referenced
this pull request
Aug 15, 2015
Adds doNotCompress list to apktool.yml
|
w/ test apk. Thanks again! |
|
Hi @iBotPeaches @agrieve |
|
I tested the build personally on win & linux @pwelyn . This is not a problem. I've removed your link. If you want to upload a log, you can do so without a password protected file. |
|
Hi @iBotPeaches http://pan.baidu.com/s/1dDpYNeh |
|
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx The maximum length of this string is |
|
Okay, thanks @rover12421 a bit late on my part, but I duplicated this. APKs that have a large amount of non-compressed resources push the command executed over the limit for Windows (32k chars).
So we might be able to get away just reading the file extension(s) of the "non-compressed" resources and working from that. However, can a situation exist where the same extension is used in both a compressed & non-compressed manor? IE: In the above stacktrace and here (http://forum.xda-developers.com/showpost.php?p=63267387&postcount=3674) were just two extensions |
|
For better compatibility, you can put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the list of files (resources, assets, etc) that are stored in
the .apk uncompressed.
For apps that use AssetFileDescriptor.openFd(), the adding compression
will break the call.
Maintains support for the resourcesAreCompressed key, but no longer
records it when decompiling (it instead records resources.arsc in the
doNotCompress list).